improvement: do not require basic password in UI (#5812)

* Fix basic-auth.jsx: do not require password in UI

password is not PropTypes.string.isRequired, but the markup wrongly makes it mandatory

* Do not require password input in http-auth.jsx

This is used by the Authorize modal. Not sure when the similar code from basic-auth.jsx is used.

Co-authored-by: kyle shockey <kyle.shockey1@gmail.com>
This commit is contained in:
Simran
2020-03-23 00:53:04 +01:00
committed by GitHub
parent 71789160aa
commit 95e72e7c70
2 changed files with 2 additions and 4 deletions

View File

@@ -73,8 +73,7 @@ export default class BasicAuth extends React.Component {
<label>Password:</label>
{
username ? <code> ****** </code>
: <Col><Input required="required"
autoComplete="new-password"
: <Col><Input autoComplete="new-password"
name="password"
type="password"
onChange={ this.onChange }/></Col>

View File

@@ -81,8 +81,7 @@ export default class HttpAuth extends React.Component {
<label>Password:</label>
{
username ? <code> ****** </code>
: <Col><Input required="required"
autoComplete="new-password"
: <Col><Input autoComplete="new-password"
name="password"
type="password"
onChange={ this.onChange }/></Col>