bug: enum Select crashes when selecting the empty value (via #5463)

* add failing tests

* fix property access

* @babel/plugin-proposal-optional-chaining
This commit is contained in:
kyle
2019-07-12 23:05:00 -05:00
committed by GitHub
parent 747925330c
commit eaa1f4a8b4
6 changed files with 76 additions and 2 deletions

View File

@@ -0,0 +1,20 @@
openapi: "3.0.0"
info:
title: Testcase API
version: 2.0.0
paths:
'/endpoint':
get:
parameters:
- name: type
in: query
example: fruit
schema:
type: string
enum:
- fruit
- vegetable
- drink
responses:
'200':
description: 200 response

View File

@@ -0,0 +1,19 @@
swagger: "2.0"
info:
title: Testcase API
version: 2.0.0
paths:
'/endpoint':
get:
parameters:
- name: type
in: query
x-example: fruit
type: string
enum:
- fruit
- vegetable
- drink
responses:
'200':
description: 200 response

View File

@@ -0,0 +1,34 @@
/**
* @prettier
*/
describe("#5452: <Select /> crashing in Parameters", function() {
describe("in OpenAPI 3", () => {
it("should not result in a render error", function() {
cy.visit("http://localhost:3230/?url=/documents/bugs/5452/openapi.yaml")
.get("#operations-default-get_endpoint")
.click()
.get(".parameters > tbody > tr > .col > select")
.select("")
.get(".parameters > tbody > tr > .col > select")
.should("exist")
.select("fruit")
.get(".parameters > tbody > tr > .col > select")
.should("exist")
})
})
describe("in Swagger 2", () => {
it("should not result in a render error", function() {
cy.visit("http://localhost:3230/?url=/documents/bugs/5452/swagger.yaml")
.get("#operations-default-get_endpoint")
.click()
.get(".parameters > tbody > tr > .col > select")
.select("")
.get(".parameters > tbody > tr > .col > select")
.should("exist")
.select("fruit")
.get(".parameters > tbody > tr > .col > select")
.should("exist")
})
})
})