From cb9804b5ca2d236b032c3ca388fea806b00ce8ec Mon Sep 17 00:00:00 2001 From: kyle Date: Thu, 26 Oct 2017 11:58:54 -0700 Subject: [PATCH 1/3] Create pull_request_template.md --- .github/pull_request_template.md | 33 ++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..dc4f0cba --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,33 @@ + + +## Description + + +## Motivation and Context + + + + + +## How Has This Been Tested? + + + + +## Screenshots (if appropriate): + + +## Types of changes + +- [ ] Bug fix (non-breaking change which fixes an issue) +- [ ] New feature (non-breaking change which adds functionality) +- [ ] Breaking change (fix or feature that would cause existing functionality to change) + +## Checklist: + + +- [ ] My code follows the code style of this project. +- [ ] My change requires a change to the documentation. +- [ ] I have updated the documentation accordingly. +- [ ] I have added tests to cover my changes. +- [ ] All new and existing tests passed. From 565318739c11ff9797038dc8d4a34776814d2c45 Mon Sep 17 00:00:00 2001 From: kyle Date: Thu, 26 Oct 2017 12:02:06 -0700 Subject: [PATCH 2/3] Add `no code changes` and `dependency changes` --- .github/pull_request_template.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index dc4f0cba..01b3cca6 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -19,6 +19,8 @@ ## Types of changes +- [ ] No code changes (changes to documentation, CI, metadata, etc) +- [ ] Dependency changes (any modification to dependencies in `package.json`) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) From 896e160e2b1c1c5d5dd4c5aaeef89862641e50a7 Mon Sep 17 00:00:00 2001 From: kyle Date: Thu, 26 Oct 2017 12:08:52 -0700 Subject: [PATCH 3/3] Improve spacing and section header sizes --- .github/pull_request_template.md | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 01b3cca6..194390a1 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,23 +1,30 @@ -## Description +### Description -## Motivation and Context + + +### Motivation and Context -## How Has This Been Tested? + + +### How Has This Been Tested? -## Screenshots (if appropriate): -## Types of changes +### Screenshots (if appropriate): + + + +### Types of changes - [ ] No code changes (changes to documentation, CI, metadata, etc) - [ ] Dependency changes (any modification to dependencies in `package.json`) @@ -25,7 +32,7 @@ - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) -## Checklist: +### Checklist: - [ ] My code follows the code style of this project.