From a78278e83674dc30ec9a1b821cbb04a0cc29d87d Mon Sep 17 00:00:00 2001 From: Rohit Sharma Date: Thu, 3 Apr 2025 15:20:11 +0530 Subject: [PATCH] fix(utils): fix error messages for range validation of number parameters (#10344) --- src/core/utils/index.js | 4 ++-- test/unit/core/utils.js | 16 ++++++++-------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/core/utils/index.js b/src/core/utils/index.js index d66bbe32..8d863b4d 100644 --- a/src/core/utils/index.js +++ b/src/core/utils/index.js @@ -304,13 +304,13 @@ export const propChecker = (props, nextProps, objectList=[], ignoreList=[]) => { export const validateMaximum = ( val, max ) => { if (val > max) { - return `Value must be less than ${max}` + return `Value must be less than or equal to ${max}` } } export const validateMinimum = ( val, min ) => { if (val < min) { - return `Value must be greater than ${min}` + return `Value must be greater than or equal to ${min}` } } diff --git a/test/unit/core/utils.js b/test/unit/core/utils.js index 18b0482e..80e7654d 100644 --- a/test/unit/core/utils.js +++ b/test/unit/core/utils.js @@ -147,9 +147,9 @@ describe("utils", () => { }) it("returns a message for invalid input", () => { - expect(validateMaximum(1, 0)).toEqual("Value must be less than 0") - expect(validateMaximum(10, 9)).toEqual("Value must be less than 9") - expect(validateMaximum(20, 19)).toEqual("Value must be less than 19") + expect(validateMaximum(1, 0)).toEqual("Value must be less than or equal to 0") + expect(validateMaximum(10, 9)).toEqual("Value must be less than or equal to 9") + expect(validateMaximum(20, 19)).toEqual("Value must be less than or equal to 19") }) }) @@ -160,9 +160,9 @@ describe("utils", () => { }) it("returns a message for invalid input", () => { - expect(validateMinimum(-1, 0)).toEqual("Value must be greater than 0") - expect(validateMinimum(1, 2)).toEqual("Value must be greater than 2") - expect(validateMinimum(10, 20)).toEqual("Value must be greater than 20") + expect(validateMinimum(-1, 0)).toEqual("Value must be greater than or equal to 0") + expect(validateMinimum(1, 2)).toEqual("Value must be greater than or equal to 2") + expect(validateMinimum(10, 20)).toEqual("Value must be greater than or equal to 20") }) }) @@ -940,7 +940,7 @@ describe("utils", () => { maximum: 0 } value = 1 - assertValidateParam(param, value, ["Value must be less than 0"]) + assertValidateParam(param, value, ["Value must be less than or equal to 0"]) // invalid number with minimum:0 param = { @@ -949,7 +949,7 @@ describe("utils", () => { minimum: 0 } value = -10 - assertValidateParam(param, value, ["Value must be greater than 0"]) + assertValidateParam(param, value, ["Value must be greater than or equal to 0"]) }) it("validates optional numbers", () => {