feature: allowEmptyValue controls (#4788)

* add baseline tests

* coerce empty strings to null when updating parameter values

* add ParameterIncludeEmpty

* add redux management for empty parameter value inclusion state

* use name+in keying for state management instead of hash keying

* update new redux method usages to name+in keying

* coerce empty Immutable iterables in onChangeWrapper

* OAS3 tests & support

* add included empty parameters to requests before dispatching to Swagger Client

* make empty inclusion interface prettier

* add tests for #4587

* linter fixes

* check for truthy value before reaching into property

test/core/plugins/spec/actions.js

@@ -1,7 +1,7 @@
 /* eslint-env mocha */
 import expect, { createSpy } from "expect"
 import { fromJS } from "immutable"
-import { execute, executeRequest, changeParamByIdentity } from "corePlugins/spec/actions"
+import { execute, executeRequest, changeParamByIdentity, updateEmptyParamInclusion } from "corePlugins/spec/actions"
 
 describe("spec plugin - actions", function(){
 
@@ -207,4 +207,22 @@ describe("spec plugin - actions", function(){
       })
     })
   })
+
+  describe("updateEmptyParamInclusion", function () {
+    it("should map its arguments to a payload", function () {
+      const pathMethod = ["/one", "get"]
+
+      const result = updateEmptyParamInclusion(pathMethod, "param", "query", true)
+
+      expect(result).toEqual({
+        type: "spec_update_empty_param_inclusion",
+        payload: {
+          pathMethod,
+          paramName: "param",
+          paramIn: "query",
+          includeEmptyValue: true
+        }
+      })
+    })
+  })
 })

test/core/plugins/spec/reducer.js

@@ -178,4 +178,26 @@ describe("spec plugin - reducer", function(){
       expect(value).toEqual(`{ "a": 123 }`)
     })
   })
+  describe("SPEC_UPDATE_EMPTY_PARAM_INCLUSION", function() {
+    it("should store parameter values by name+in", () => {
+      const updateParam = reducer["spec_update_empty_param_inclusion"]
+
+      const path = "/pet/post"
+      const method = "POST"
+
+      const state = fromJS({})
+
+      const result = updateParam(state, {
+        payload: {
+          pathMethod: [path, method],
+          paramName: "param",
+          paramIn: "query",
+          includeEmptyValue: true
+        }
+      })
+
+      const response = result.getIn(["meta", "paths", path, method, "parameter_inclusions", "param.query"])
+      expect(response).toEqual(true)
+    })
+  })
 })

test/core/plugins/spec/selectors.js

@@ -14,7 +14,8 @@ import Petstore from "./assets/petstore.json"
 import {
   operationWithMeta,
   parameterWithMeta,
-  parameterWithMetaByIdentity
+  parameterWithMetaByIdentity,
+  parameterInclusionSettingFor
 } from "../../../../src/core/plugins/spec/selectors"
 
 describe("spec plugin - selectors", function(){
@@ -712,4 +713,42 @@ describe("spec plugin - selectors", function(){
       })
     })
   })
+  describe("parameterInclusionSettingFor", function() {
+    it("should support getting name+in param inclusion settings", function () {
+      const param = fromJS({
+        name: "param",
+        in: "query",
+        allowEmptyValue: true
+      })
+
+      const state = fromJS({
+        json: {
+          paths: {
+            "/": {
+              "get": {
+                parameters: [
+                  param
+                ]
+              }
+            }
+          }
+        },
+        meta: {
+          paths: {
+            "/": {
+              "get": {
+                "parameter_inclusions": {
+                  [`param.query`]: true
+                }
+              }
+            }
+          }
+        }
+      })
+
+      const result = parameterInclusionSettingFor(state, ["/", "get"], "param", "query")
+
+      expect(result).toEqual(true)
+    })
+  })
 })