From bcd36ff6674e6c3979bc80e5ade47159862f33b3 Mon Sep 17 00:00:00 2001 From: Kyle Shockey Date: Wed, 26 Apr 2017 18:11:27 -0700 Subject: [PATCH 1/2] Fix #2937 --- webpack-dist.config.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/webpack-dist.config.js b/webpack-dist.config.js index 6ee19255..48410ad9 100644 --- a/webpack-dist.config.js +++ b/webpack-dist.config.js @@ -22,7 +22,11 @@ module.exports = require('./make-webpack-config.js')({ }, externals: function(context, request, cb) { - if(node_modules.indexOf(request) !== -1) { + // webpack injects some stuff into the resulting file, + // these libs need to be pulled in to keep that working. + let exceptionsForWebpack = ["ieee754", "base64-js"] + if(node_modules.indexOf(request) !== -1 || exceptionsForWebpack.indexOf(request) !== -1) { + console.log(request) cb(null, 'commonjs ' + request) return; } From 494048e80946464cb84215968c8137db0b892e43 Mon Sep 17 00:00:00 2001 From: Kyle Shockey Date: Wed, 26 Apr 2017 18:23:57 -0700 Subject: [PATCH 2/2] Fix #2937 --- package.json | 2 ++ 1 file changed, 2 insertions(+) diff --git a/package.json b/package.json index eb4eb829..d03c06a5 100644 --- a/package.json +++ b/package.json @@ -36,10 +36,12 @@ }, "dependencies": { "babel-polyfill": "^6.23.0", + "base64-js": "^1.2.0", "brace": "0.7.0", "deep-extend": "0.4.1", "expect": "1.20.2", "getbase": "^2.8.2", + "ieee754": "^1.1.8", "immutable": "^3.x.x", "js-yaml": "^3.5.5", "less": "2.7.1",