fix: Updating select to pass in a better prop; updating test to do a better check (#6385)

fixes #6372

src/core/plugins/oas3/components/servers.jsx

@@ -104,13 +104,12 @@ export default class Servers extends React.Component {
     return (
       <div className="servers">
         <label htmlFor="servers">
-          <select onChange={ this.onServerChange }>
+          <select onChange={ this.onServerChange } value={currentServer}>
             { servers.valueSeq().map(
               ( server ) =>
               <option
                 value={ server.get("url") }
-                key={ server.get("url") }
-                selected={ currentServer === server.get("url") }>
+                key={ server.get("url") }>
                 { server.get("url") }
                 { server.get("description") && ` - ${server.get("description")}` }
               </option>

test/e2e-cypress/tests/bugs/6351.js

@@ -3,11 +3,9 @@
 describe("#6351: Server dropdown should change when switched via oas3Actions.setSelectedServer", () => {
   it("should show different selected server", () => {
     cy.visit("/?url=/documents/bugs/6351.yaml")
-      .get("select")
-      .contains("http://testserver1.com")
+      .get("select").should("have.value", "http://testserver1.com")
       .window()
       .then(win => win.ui.oas3Actions.setSelectedServer("http://testserver2.com"))
-      .get("select")
-      .contains("http://testserver2.com")
+      .get("select").should("have.value", "http://testserver2.com")
   })
 })