kyy/swagger-ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Updating select to pass in a better prop; updating test to do a better check (#6385)

Browse Source 
fixes #6372
This commit is contained in:
ben-smartbear
2020-09-10 19:06:46 +01:00
committed by GitHub
parent 26a0fd8e64
commit 6ad418d0ab
2 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/core/plugins/oas3/components/servers.jsx
View File

@@ -104,13 +104,12 @@ export default class Servers extends React.Component {
return ( return (
<div className="servers"> <div className="servers">
<label htmlFor="servers"> <label htmlFor="servers">
<select onChange={ this.onServerChange }> <select onChange={ this.onServerChange } value={currentServer}>
{ servers.valueSeq().map( { servers.valueSeq().map(
( server ) => ( server ) =>
<option <option
value={ server.get("url") } value={ server.get("url") }
key={ server.get("url") } key={ server.get("url") }>
selected={ currentServer === server.get("url") }>
{ server.get("url") } { server.get("url") }
{ server.get("description") && ` - ${server.get("description")}` } { server.get("description") && ` - ${server.get("description")}` }
</option> </option>

6
test/e2e-cypress/tests/bugs/6351.js
View File

@@ -3,11 +3,9 @@
describe("#6351: Server dropdown should change when switched via oas3Actions.setSelectedServer", () => { describe("#6351: Server dropdown should change when switched via oas3Actions.setSelectedServer", () => {
it("should show different selected server", () => { it("should show different selected server", () => {
cy.visit("/?url=/documents/bugs/6351.yaml") cy.visit("/?url=/documents/bugs/6351.yaml")
.get("select") .get("select").should("have.value", "http://testserver1.com")
.contains("http://testserver1.com")
.window() .window()
.then(win => win.ui.oas3Actions.setSelectedServer("http://testserver2.com")) .then(win => win.ui.oas3Actions.setSelectedServer("http://testserver2.com"))
.get("select") .get("select").should("have.value", "http://testserver2.com")
.contains("http://testserver2.com")
}) })
}) })