kyy/swagger-ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove unused non-compliant system method inside 'err' reducer (#6330)

Browse Source
This commit is contained in:
Tim Lai
2020-08-20 15:51:30 -07:00
committed by GitHub
parent 9bde965015
commit 6742cbd38b
2 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/core/plugins/err/error-transformers/hook.js
View File

@@ -7,9 +7,13 @@ const errorTransformers = [
ParameterOneOf ParameterOneOf
] ]
export default function transformErrors (errors, system) { export default function transformErrors (errors) {
// Dev note: unimplemented artifact where
// jsSpec: system.specSelectors.specJson().toJS()
// regardless, to be compliant with redux@4, instead of calling the store method here,
// jsSpec should be pass down as an argument,
let inputs = { let inputs = {
jsSpec: system.specSelectors.specJson().toJS() jsSpec: {}
} }
let transformedErrors = reduce(errorTransformers, (result, transformer) => { let transformedErrors = reduce(errorTransformers, (result, transformer) => {

12
src/core/plugins/err/reducers.js
View File

@@ -19,13 +19,13 @@ let DEFAULT_ERROR_STRUCTURE = {
message: "Unknown error" message: "Unknown error"
} }
export default function(system) { export default function() {
return { return {
[NEW_THROWN_ERR]: (state, { payload }) => { [NEW_THROWN_ERR]: (state, { payload }) => {
let error = Object.assign(DEFAULT_ERROR_STRUCTURE, payload, {type: "thrown"}) let error = Object.assign(DEFAULT_ERROR_STRUCTURE, payload, {type: "thrown"})
return state return state
.update("errors", errors => (errors || List()).push( fromJS( error )) ) .update("errors", errors => (errors || List()).push( fromJS( error )) )
.update("errors", errors => transformErrors(errors, system.getSystem())) .update("errors", errors => transformErrors(errors))
}, },
[NEW_THROWN_ERR_BATCH]: (state, { payload }) => { [NEW_THROWN_ERR_BATCH]: (state, { payload }) => {
@@ -34,7 +34,7 @@ export default function(system) {
}) })
return state return state
.update("errors", errors => (errors || List()).concat( fromJS( payload )) ) .update("errors", errors => (errors || List()).concat( fromJS( payload )) )
.update("errors", errors => transformErrors(errors, system.getSystem())) .update("errors", errors => transformErrors(errors))
}, },
[NEW_SPEC_ERR]: (state, { payload }) => { [NEW_SPEC_ERR]: (state, { payload }) => {
@@ -42,7 +42,7 @@ export default function(system) {
error = error.set("type", "spec") error = error.set("type", "spec")
return state return state
.update("errors", errors => (errors || List()).push( fromJS(error)).sortBy(err => err.get("line")) ) .update("errors", errors => (errors || List()).push( fromJS(error)).sortBy(err => err.get("line")) )
.update("errors", errors => transformErrors(errors, system.getSystem())) .update("errors", errors => transformErrors(errors))
}, },
[NEW_SPEC_ERR_BATCH]: (state, { payload }) => { [NEW_SPEC_ERR_BATCH]: (state, { payload }) => {
@@ -51,7 +51,7 @@ export default function(system) {
}) })
return state return state
.update("errors", errors => (errors || List()).concat(fromJS(payload))) .update("errors", errors => (errors || List()).concat(fromJS(payload)))
.update("errors", errors => transformErrors(errors, system.getSystem())) .update("errors", errors => transformErrors(errors))
}, },
[NEW_AUTH_ERR]: (state, { payload }) => { [NEW_AUTH_ERR]: (state, { payload }) => {
@@ -60,7 +60,7 @@ export default function(system) {
error = error.set("type", "auth") error = error.set("type", "auth")
return state return state
.update("errors", errors => (errors || List()).push( fromJS(error)) ) .update("errors", errors => (errors || List()).push( fromJS(error)) )
.update("errors", errors => transformErrors(errors, system.getSystem())) .update("errors", errors => transformErrors(errors))
}, },
[CLEAR]: (state, { payload }) => { [CLEAR]: (state, { payload }) => {