From 4db2edcad247dc76afdf670e9cfcaac88c25a82b Mon Sep 17 00:00:00 2001 From: Mahtis Michel Date: Wed, 24 Feb 2021 23:32:25 +0100 Subject: [PATCH] feat: verbose Failed to fetch error (#6938) * feat: verbose Failed to fetch error * refactor: disable console.error in src/core/plugins/spec/actions.js Co-authored-by: Tim Lai --- src/core/components/live-response.jsx | 5 ++--- src/core/plugins/spec/actions.js | 16 ++++++++++------ 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/src/core/components/live-response.jsx b/src/core/components/live-response.jsx index d1b549f3..4bb9d8cd 100644 --- a/src/core/components/live-response.jsx +++ b/src/core/components/live-response.jsx @@ -69,6 +69,7 @@ export default class LiveResponse extends React.Component { return {key}: {joinedHeaders} }) const hasHeaders = returnObject.length !== 0 + const Markdown = getComponent("Markdown", true) return (
@@ -101,9 +102,7 @@ export default class LiveResponse extends React.Component { { - isError ? - {`${response.get("name")}: ${response.get("message")}`} - + isError ? : null } { diff --git a/src/core/plugins/spec/actions.js b/src/core/plugins/spec/actions.js index 37934126..147de2aa 100644 --- a/src/core/plugins/spec/actions.js +++ b/src/core/plugins/spec/actions.js @@ -256,7 +256,7 @@ export const requestResolvedSubtree = path => system => { const isPathAlreadyBatched = requestBatch .map(arr => arr.join("@@")) .indexOf(path.join("@@")) > -1 - + if(isPathAlreadyBatched) { return } @@ -376,9 +376,9 @@ export const executeRequest = (req) => let { pathName, method, operation } = req let { requestInterceptor, responseInterceptor } = getConfigs() - + let op = operation.toJS() - + // ensure that explicitly-included params are in the request if (operation && operation.get("parameters")) { @@ -439,8 +439,8 @@ export const executeRequest = (req) => } ) .filter( - (value, key) => (Array.isArray(value) - ? value.length !== 0 + (value, key) => (Array.isArray(value) + ? value.length !== 0 : !isEmptyValue(value) ) || requestBodyInclusionSetting.get(key) ) @@ -476,7 +476,11 @@ export const executeRequest = (req) => } ) .catch( err => { - console.error(err) + // console.error(err) + if(err.message === "Failed to fetch") { + err.name = "" + err.message = "**Failed to fetch.** \n**Possible Reasons:** \n - CORS \n - Network Failure \n - URL scheme must be \"http\" or \"https\" for CORS request." + } specActions.setResponse(req.pathName, req.method, { error: true, err: serializeError(err) })