Fixes #3633
Make sure PrimitiveModel uses the schema's title first and then falls back to the passed-in `name` property. Added enzyme test for functionality.
This commit is contained in:
@@ -23,6 +23,7 @@ export default class Primitive extends Component {
|
|||||||
let format = schema.get("format")
|
let format = schema.get("format")
|
||||||
let xml = schema.get("xml")
|
let xml = schema.get("xml")
|
||||||
let enumArray = schema.get("enum")
|
let enumArray = schema.get("enum")
|
||||||
|
let title = schema.get("title") || name
|
||||||
let description = schema.get("description")
|
let description = schema.get("description")
|
||||||
let properties = schema.filter( ( v, key) => ["enum", "type", "format", "description", "$$ref"].indexOf(key) === -1 )
|
let properties = schema.filter( ( v, key) => ["enum", "type", "format", "description", "$$ref"].indexOf(key) === -1 )
|
||||||
const Markdown = getComponent("Markdown")
|
const Markdown = getComponent("Markdown")
|
||||||
@@ -30,7 +31,7 @@ export default class Primitive extends Component {
|
|||||||
|
|
||||||
return <span className="model">
|
return <span className="model">
|
||||||
<span className="prop">
|
<span className="prop">
|
||||||
{ name && <span className={`${depth === 1 && "model-title"} prop-name`}>{ name }</span> }
|
{ name && <span className={`${depth === 1 && "model-title"} prop-name`}>{ title }</span> }
|
||||||
<span className="prop-type">{ type }</span>
|
<span className="prop-type">{ type }</span>
|
||||||
{ format && <span className="prop-format">(${format})</span>}
|
{ format && <span className="prop-format">(${format})</span>}
|
||||||
{
|
{
|
||||||
|
|||||||
49
test/components/primitive-model.js
Normal file
49
test/components/primitive-model.js
Normal file
@@ -0,0 +1,49 @@
|
|||||||
|
/* eslint-env mocha */
|
||||||
|
import React from "react"
|
||||||
|
import expect from "expect"
|
||||||
|
import { shallow } from "enzyme"
|
||||||
|
import { fromJS } from "immutable"
|
||||||
|
import PrimitiveModel from "components/primitive-model"
|
||||||
|
|
||||||
|
describe("<PrimitiveModel/>", function() {
|
||||||
|
describe("Model name", function() {
|
||||||
|
const dummyComponent = () => null
|
||||||
|
const components = {
|
||||||
|
Markdown: dummyComponent,
|
||||||
|
EnumModel: dummyComponent
|
||||||
|
}
|
||||||
|
const props = {
|
||||||
|
getComponent: c => components[c],
|
||||||
|
name: "Name from props",
|
||||||
|
depth: 1,
|
||||||
|
schema: fromJS({
|
||||||
|
type: "string",
|
||||||
|
title: "Custom model title"
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
it("renders the schema's title", function() {
|
||||||
|
// When
|
||||||
|
const wrapper = shallow(<PrimitiveModel {...props}/>)
|
||||||
|
const modelTitleEl = wrapper.find("span.model-title")
|
||||||
|
expect(modelTitleEl.length).toEqual(1)
|
||||||
|
|
||||||
|
// Then
|
||||||
|
expect( modelTitleEl.text() ).toEqual( "Custom model title" )
|
||||||
|
})
|
||||||
|
|
||||||
|
it("falls back to the passed-in `name` prop for the title", function() {
|
||||||
|
// When
|
||||||
|
props.schema = fromJS({
|
||||||
|
type: "string"
|
||||||
|
})
|
||||||
|
const wrapper = shallow(<PrimitiveModel {...props}/>)
|
||||||
|
const modelTitleEl = wrapper.find("span.model-title")
|
||||||
|
expect(modelTitleEl.length).toEqual(1)
|
||||||
|
|
||||||
|
// Then
|
||||||
|
expect( modelTitleEl.text() ).toEqual( "Name from props" )
|
||||||
|
})
|
||||||
|
|
||||||
|
})
|
||||||
|
} )
|
||||||
Reference in New Issue
Block a user