fix: empty ModelExample rendering in a Response w/o content (via #5504)

* add failing test

* use falsy notSetValue for oas3SchemaForContentType
This commit is contained in:
kyle
2019-07-29 22:15:19 -05:00
committed by GitHub
parent e895fb544f
commit 39f8ceba55
3 changed files with 22 additions and 1 deletions

View File

@@ -109,7 +109,7 @@ export default class Response extends React.Component {
// Goal: find a schema value for `schema`
if(isOAS3) {
const oas3SchemaForContentType = activeMediaType.get("schema", Map({}))
const oas3SchemaForContentType = activeMediaType.get("schema")
schema = oas3SchemaForContentType ? inferSchema(oas3SchemaForContentType.toJS()) : null
specPathWithPossibleSchema = oas3SchemaForContentType ? List(["content", this.state.responseContentType, "schema"]) : specPath

View File

@@ -0,0 +1,10 @@
openapi: 3.0.2
info:
title: Response without a schema
version: 1.0.0
paths:
/foo:
get:
responses:
'200':
description: OK

View File

@@ -0,0 +1,11 @@
// http://github.com/swagger-api/swagger-ui/issues/5453
describe("#5453: Responses w/o `content` should not render ModelExample", () => {
it("should not render a ModelExample section", () => {
cy.visit("/?url=/documents/bugs/5453.yaml")
.get("#operations-default-get_foo")
.click()
.get(".responses-inner")
.should("not.have.descendants", ".model-example")
})
})