fix: escape $ in curl request bodies and headers (#6245)

This address a bug where a `$` character in a request body or header
would not be properly escaped in a string in the generated curl command.

Fixes #5390
This commit is contained in:
Alec Theriault
2020-08-03 12:07:06 -04:00
committed by GitHub
parent 28b3b4c4b6
commit 225a915cf8
2 changed files with 15 additions and 2 deletions

View File

@@ -26,7 +26,7 @@ export default function curl( request ){
for( let p of request.get("headers").entries() ){
let [ h,v ] = p
curlified.push( "-H " )
curlified.push( `"${h}: ${v}"` )
curlified.push( `"${h}: ${v.replace("$", "\\$")}"` )
isMultipartFormDataRequest = isMultipartFormDataRequest || /^content-type$/i.test(h) && /^multipart\/form-data$/i.test(v)
}
}
@@ -44,7 +44,7 @@ export default function curl( request ){
}
} else {
curlified.push( "-d" )
curlified.push( JSON.stringify( request.get("body") ).replace(/\\n/g, "") )
curlified.push( JSON.stringify( request.get("body") ).replace(/\\n/g, "").replace("$", "\\$") )
}
} else if(!request.get("body") && request.get("method") === "POST") {
curlified.push( "-d" )