improve(deeplink): support utf16 tags and IDs (via #4921)

* ref #3958, support utf16 fragments on the deeplink plugin
* put -> head for UTF16 operation
this is a temporary fix, eventually we will run out
of methods and need to use a new targeting strategy
* drop obsolete %20 decoder
* add full test suite for UTF16 operation
* use encodeURIComponent when setting hash
* drop obsolete test cases
This commit is contained in:
James ZHANG
2018-10-19 05:55:30 +08:00
committed by kyle
parent 3c3b7e0bf1
commit 1791759de5
5 changed files with 87 additions and 8 deletions

View File

@@ -25,6 +25,14 @@ paths:
application/json:
schema:
type: object
/utf16fragments:
head:
operationId: "пошел"
tags: ["шеллы"]
summary: an operation
responses:
"200":
description: ok
/withUnderscores:
patch:
operationId: "underscore_Operation"

View File

@@ -17,6 +17,10 @@ paths:
responses:
"200":
description: ok
/utf16fragments:
head:
operationId: "пошел"
tags: ["шеллы"]
/withUnderscores:
patch:
operationId: "underscore_Operation"
@@ -28,7 +32,3 @@ paths:
/noOperationId:
put:
tags: ["tagTwo"]
summary: an operation
responses:
"200":
description: ok

View File

@@ -114,6 +114,41 @@ describe("Deep linking feature", () => {
})
})
describe("Operation with UTF-16 characters", () => {
const elementToGet = ".opblock-head"
const correctElementId = "operations-шеллы-пошел"
const correctFragment = "#/%D1%88%D0%B5%D0%BB%D0%BB%D1%8B/%D0%BF%D0%BE%D1%88%D0%B5%D0%BB"
const correctHref = "#/шеллы/пошел"
it("should generate a correct element ID", () => {
cy.get(elementToGet)
.should("have.id", correctElementId)
})
it("should add the correct element fragment to the URL when expanded", () => {
cy.get(elementToGet)
.click()
.window()
.should("have.deep.property", "location.hash", correctFragment)
})
it("should provide an anchor link that has the correct fragment as href", () => {
cy.get(elementToGet)
.find("a")
.should("have.attr", "href", correctHref)
.click()
.should("have.attr", "href", correctHref) // should be valid after expanding
})
it("should expand the operation when reloaded", () => {
cy.visit(`${baseUrl}${correctFragment}`)
.reload()
.get(`${elementToGet}.is-open`)
.should("exist")
})
})
describe("Operation with no operationId", () => {
const elementToGet = ".opblock-put"
const correctElementId = "operations-tagTwo-put_noOperationId"
@@ -276,6 +311,41 @@ describe("Deep linking feature", () => {
})
})
describe("Operation with UTF-16 characters", () => {
const elementToGet = ".opblock-head"
const correctElementId = "operations-шеллы-пошел"
const correctFragment = "#/%D1%88%D0%B5%D0%BB%D0%BB%D1%8B/%D0%BF%D0%BE%D1%88%D0%B5%D0%BB"
const correctHref = "#/шеллы/пошел"
it("should generate a correct element ID", () => {
cy.get(elementToGet)
.should("have.id", correctElementId)
})
it("should add the correct element fragment to the URL when expanded", () => {
cy.get(elementToGet)
.click()
.window()
.should("have.deep.property", "location.hash", correctFragment)
})
it("should provide an anchor link that has the correct fragment as href", () => {
cy.get(elementToGet)
.find("a")
.should("have.attr", "href", correctHref)
.click()
.should("have.attr", "href", correctHref) // should be valid after expanding
})
it("should expand the operation when reloaded", () => {
cy.visit(`${baseUrl}${correctFragment}`)
.reload()
.get(`${elementToGet}.is-open`)
.should("exist")
})
})
describe("Operation with no operationId", () => {
const elementToGet = ".opblock-put"
const correctElementId = "operations-tagTwo-put_noOperationId"