From ce532ed81b7550a7e3ddae019a7deb30d7245a40 Mon Sep 17 00:00:00 2001 From: Mohsen Azimi Date: Fri, 30 Jan 2015 15:25:12 -0800 Subject: [PATCH 1/2] Take out `checkConsoleErrors` from inside title check `it` inside another `it` will not get executed. --- src/test/e2e/index.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/test/e2e/index.js b/src/test/e2e/index.js index 93496809..2af18f0d 100644 --- a/src/test/e2e/index.js +++ b/src/test/e2e/index.js @@ -61,13 +61,14 @@ describe('basics', function (done) { if (hasTitle) { expect(title).to.contain('Swagger UI'); - checkConsoleErrors(); done(); } return hasTitle; }); }, 1000); }); + + checkConsoleErrors(); }); describe('cleanup', function () { From 21262ddb8e96e325e2d1d68c0726c3e0083b9fbb Mon Sep 17 00:00:00 2001 From: Mohsen Azimi Date: Fri, 30 Jan 2015 15:39:11 -0800 Subject: [PATCH 2/2] Sleep instead of wait --- src/test/e2e/index.js | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/src/test/e2e/index.js b/src/test/e2e/index.js index 2af18f0d..68eb7845 100644 --- a/src/test/e2e/index.js +++ b/src/test/e2e/index.js @@ -40,6 +40,7 @@ function checkConsoleErrors () { errors.push(log); } }); + expect(errors).to.be.empty; done(); @@ -55,17 +56,11 @@ describe('basics', function (done) { }); it('should have "Swagger UI" in title', function (done) { - driver.wait(function() { - return driver.getTitle().then(function(title) { - var hasTitle = title.indexOf('Swagger UI') > -1; - - if (hasTitle) { - expect(title).to.contain('Swagger UI'); - done(); - } - return hasTitle; - }); - }, 1000); + driver.sleep(200); + driver.getTitle().then(function(title) { + expect(title).to.contain('Swagger UI'); + done(); + }); }); checkConsoleErrors();