From 02e0515b9784a97c2dab392111ecbc8f82f055dd Mon Sep 17 00:00:00 2001
From: Tim Lai <timothy.lai@gmail.com>
Date: Mon, 17 Aug 2020 14:55:17 -0700
Subject: [PATCH] fix(cypress): deep-linking tests should use cy.location
 (#6309)

---
 .../tests/features/deep-linking.js            | 25 +++++++++++--------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/test/e2e-cypress/tests/features/deep-linking.js b/test/e2e-cypress/tests/features/deep-linking.js
index 257c00fa..9108c4fd 100644
--- a/test/e2e-cypress/tests/features/deep-linking.js
+++ b/test/e2e-cypress/tests/features/deep-linking.js
@@ -201,8 +201,9 @@ function OperationDeeplinkTestFactory({ baseUrl, elementToGet, correctElementId,
     cy.visit(baseUrl)
       .get(elementToGet)
       .click()
-      .window()
-      .should("have.deep.property", "location.hash", correctFragment)
+    cy.location().should((loc) => {
+      expect(loc.hash).to.eq(correctFragment)
+    })
   })
 
   it("should provide an anchor link that has the correct fragment as href", () => {
@@ -211,8 +212,9 @@ function OperationDeeplinkTestFactory({ baseUrl, elementToGet, correctElementId,
       .find("a")
       .should("have.attr", "href", correctHref)
       .click()
-      .window()
-      .should("have.deep.property", "location.hash", correctFragment)
+    cy.location().should((loc) => {
+      expect(loc.hash).to.eq(correctFragment)
+    })
   })
 
   it("should expand the operation when reloaded", () => {
@@ -225,8 +227,9 @@ function OperationDeeplinkTestFactory({ baseUrl, elementToGet, correctElementId,
     cy.visit(`${baseUrl}${correctFragment}`)
       .reload()
       .should("exist")
-      .window()
-      .should("have.deep.property", "location.hash", correctFragment)
+    cy.location().should((loc) => {
+      expect(loc.hash).to.eq(correctFragment)
+    })
   })
 
   it("should expand a tag with docExpansion disabled", () => {
@@ -254,8 +257,9 @@ function TagDeeplinkTestFactory({ baseUrl, elementToGet, correctElementId, corre
       .get(elementToGet)
       .click()
       .click() // tags need two clicks because they're expanded by default
-      .window()
-      .should("have.deep.property", "location.hash", correctFragment)
+    cy.location().should((loc) => {
+      expect(loc.hash).to.eq(correctFragment)
+    })
   })
 
   it("should provide an anchor link that has the correct fragment as href", () => {
@@ -275,8 +279,9 @@ function TagDeeplinkTestFactory({ baseUrl, elementToGet, correctElementId, corre
     cy.visit(`${baseUrl}${correctFragment}`)
       .reload()
       .should("exist")
-      .window()
-      .should("have.deep.property", "location.hash", correctFragment)
+    cy.location().should((loc) => {
+      expect(loc.hash).to.eq(correctFragment)
+    })
   })
 
   it("should expand a tag with docExpansion disabled", () => {