Completes the Generic / HmEG-aware / App-specific separation started in
f6b6e74. The legacy EgPlugin / EngineBridge / EngineBridge.Client /
EngineBridge.Probe modules are moved into their proper tiers, namespaces
and csproj/sln entries are renamed, and the HmegDirectStateProvider
lambdas are finally populated with real handles from the EgBim plugin
host. A new Recordingtest.Architecture.Tests project enforces the tier
rule at build time.
Moves (git mv + csproj/RootNamespace/AssemblyName rename + sln):
src/Recordingtest.EgPlugin
-> src/Sut/EgBim/Recordingtest.Sut.EgBim.PluginHost
src/Recordingtest.EngineBridge
-> src/Hmeg/Recordingtest.Hmeg.Catalog
src/Recordingtest.EngineBridge.Client
-> src/Hmeg/Recordingtest.Hmeg.Bridge.Client
src/Recordingtest.EngineBridge.Probe
-> src/Hmeg/Recordingtest.Hmeg.Catalog.Probe
tests/Recordingtest.EgPlugin.Tests
-> tests/Sut/EgBim/Recordingtest.Sut.EgBim.PluginHost.Tests
tests/Recordingtest.EngineBridge.Tests
-> tests/Hmeg/Recordingtest.Hmeg.Catalog.Tests
tests/Recordingtest.EngineBridge.IntegrationTests
-> tests/Hmeg/Recordingtest.Hmeg.Catalog.IntegrationTests
Namespace rename applied across all .cs files and csproj RootNamespace:
Recordingtest.EgPlugin -> Recordingtest.Sut.EgBim.PluginHost
Recordingtest.EngineBridge -> Recordingtest.Hmeg.Catalog
Recordingtest.EngineBridge.Client -> Recordingtest.Hmeg.Bridge.Client
Recordingtest.EngineBridge.Probe -> Recordingtest.Hmeg.Catalog.Probe
New: tests/Recordingtest.Architecture.Tests/
DependencyGraphTests walks Assembly.GetReferencedAssemblies() for each
tier and fails if a forbidden reference leaks in:
- Generic modules must not reference HmEG or any app-specific DLL
- HmEG-aware modules must not reference app-specific DLLs
- Recordingtest.Hmeg.Bridge must reference HmEG (positive check)
11 tests, all passing. Prevents future drift from CLAUDE.md §8.1.
Engine-bridge v3 wire-up (HmEgBridgePlugin.BuildProvider):
Previously the HmegDirectStateProvider lambdas returned null and the
chain fell through to reflection. They now call directly into the
EditorPlugin base class that HmEgBridgePlugin inherits:
spaceProvider = () => RootSpace
// AppManager.ViewportManager.RootSpace
viewportProvider = () => View
// EGViewport : Control, HmEGViewport
documentPathProvider = () => AppManager?.FileManager?.CurrentFile
Every lambda is wrapped in try/catch so plugin construction still
cannot throw back into the SUT. Editor02.HmEGAppManager.dll added as
a reference on Recordingtest.Sut.EgBim.PluginHost.csproj — app-
specific tier, which is allowed by the architecture tests.
Entry points were confirmed from read-only review of the SUT sources at
D:\GiteaAll\EG-BIM_Modeler\EditorPluginInterface\EditorPlugin.cs
D:\GiteaAll\EG-BIM_Modeler\HmEGApplicationManagementLibrary\HmEGAppManager.cs
D:\GiteaAll\EG-BIM_Modeler\HmEGApplicationManagementLibrary\SubManager\FileManager.cs
closing out Q1/Q2/Q6/Q7 from docs/hmeg-api-survey.md.
Tests: 115 -> 126 (+11 Architecture), 0 failures.
Next step: live verification of /scene /camera /selection with a real
SUT session; any discrepancy in HmegDirectStateProvider reflection will
be tightened after observing real HmEG camera field names.
Ref: #10 follow-up, #14 follow-up, docs/contracts/generic-sut-split.md.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
94 lines
3.2 KiB
C#
94 lines
3.2 KiB
C#
using Recordingtest.Bridge;
|
|
using Recordingtest.Sut.EgBim.PluginHost;
|
|
using Xunit;
|
|
|
|
namespace Recordingtest.Sut.EgBim.PluginHost.Tests;
|
|
|
|
public class ChainedEngineStateProviderTests
|
|
{
|
|
private sealed class ScriptedProvider : IEngineStateProvider
|
|
{
|
|
public IReadOnlyList<string> SelectedIds = Array.Empty<string>();
|
|
public CameraSnapshot Camera = new(
|
|
new double[] { 0, 0, 0 },
|
|
new double[] { 0, 0, 0 },
|
|
new double[] { 0, 0, 1 },
|
|
45.0);
|
|
public SceneSnapshot Scene = new(0, null);
|
|
public bool Render = true;
|
|
|
|
public IReadOnlyList<string> GetSelectedIds() => SelectedIds;
|
|
public CameraSnapshot GetCamera() => Camera;
|
|
public SceneSnapshot GetScene() => Scene;
|
|
public bool GetRenderComplete() => Render;
|
|
}
|
|
|
|
[Fact]
|
|
public void Selection_Primary_NonEmpty_Wins()
|
|
{
|
|
var p = new ScriptedProvider { SelectedIds = new[] { "a" } };
|
|
var f = new ScriptedProvider { SelectedIds = new[] { "fallback" } };
|
|
var c = new ChainedEngineStateProvider(p, f);
|
|
Assert.Equal(new[] { "a" }, c.GetSelectedIds());
|
|
}
|
|
|
|
[Fact]
|
|
public void Selection_Primary_Empty_Falls_Through()
|
|
{
|
|
var p = new ScriptedProvider();
|
|
var f = new ScriptedProvider { SelectedIds = new[] { "fallback" } };
|
|
var c = new ChainedEngineStateProvider(p, f);
|
|
Assert.Equal(new[] { "fallback" }, c.GetSelectedIds());
|
|
}
|
|
|
|
[Fact]
|
|
public void Camera_Primary_Default_Falls_Through()
|
|
{
|
|
var p = new ScriptedProvider();
|
|
var fc = new CameraSnapshot(new double[] { 1, 2, 3 }, new double[] { 4, 5, 6 }, new double[] { 0, 0, 1 }, 60);
|
|
var f = new ScriptedProvider { Camera = fc };
|
|
var c = new ChainedEngineStateProvider(p, f);
|
|
Assert.Equal(60.0, c.GetCamera().Fov);
|
|
}
|
|
|
|
[Fact]
|
|
public void Camera_Primary_NonDefault_Wins()
|
|
{
|
|
var pc = new CameraSnapshot(new double[] { 1, 0, 0 }, new double[] { 0, 0, 0 }, new double[] { 0, 0, 1 }, 30);
|
|
var p = new ScriptedProvider { Camera = pc };
|
|
var f = new ScriptedProvider();
|
|
var c = new ChainedEngineStateProvider(p, f);
|
|
Assert.Equal(30.0, c.GetCamera().Fov);
|
|
}
|
|
|
|
[Fact]
|
|
public void Scene_Primary_Empty_Falls_Through()
|
|
{
|
|
var p = new ScriptedProvider();
|
|
var f = new ScriptedProvider { Scene = new(7, "x.hmeg") };
|
|
var c = new ChainedEngineStateProvider(p, f);
|
|
var s = c.GetScene();
|
|
Assert.Equal(7, s.ObjectCount);
|
|
Assert.Equal("x.hmeg", s.DocumentPath);
|
|
}
|
|
|
|
[Fact]
|
|
public void Scene_Primary_Has_Path_Wins_Even_With_Zero_Objects()
|
|
{
|
|
var p = new ScriptedProvider { Scene = new(0, "primary.hmeg") };
|
|
var f = new ScriptedProvider { Scene = new(99, "fallback.hmeg") };
|
|
var c = new ChainedEngineStateProvider(p, f);
|
|
var s = c.GetScene();
|
|
Assert.Equal("primary.hmeg", s.DocumentPath);
|
|
}
|
|
|
|
[Fact]
|
|
public void Render_Primary_Always_Wins()
|
|
{
|
|
var p = new ScriptedProvider { Render = false };
|
|
var f = new ScriptedProvider { Render = true };
|
|
var c = new ChainedEngineStateProvider(p, f);
|
|
Assert.False(c.GetRenderComplete());
|
|
}
|
|
}
|