Fix smoke gaps: recorder target + VK translation, player enum + null guard (#11)

tests/Recordingtest.Recorder.Tests/RecorderTests.cs

@@ -224,6 +224,81 @@ public class RecorderTests
         Assert.Equal(new[] { 640, 480 }, parsed.Steps[0].RawCoord);
     }
 
+    [Fact]
+    public void KeyTranslator_VkCodes_ProduceExpectedStrings()
+    {
+        Assert.Equal("B", KeyTranslator.Translate(0x42).Text);
+        Assert.Equal("O", KeyTranslator.Translate(0x4F).Text);
+        Assert.Equal(KeyTranslator.KeyCategory.Printable, KeyTranslator.Translate(0x42).Category);
+        Assert.Equal("ctrl", KeyTranslator.Translate(0xA2).Text);
+        Assert.Equal(KeyTranslator.KeyCategory.Modifier, KeyTranslator.Translate(0xA2).Category);
+        Assert.Equal("enter", KeyTranslator.Translate(0x0D).Text);
+        Assert.Equal(KeyTranslator.KeyCategory.Named, KeyTranslator.Translate(0x0D).Category);
+        Assert.Equal("f1", KeyTranslator.Translate(0x70).Text);
+    }
+
+    [Fact]
+    public void DragCollapser_PrintableKeys_CollapseIntoSingleTypeStep()
+    {
+        var el = MakeRectElement("Canvas", 0, 0, 800, 600);
+        var path = "Window[@Name='Canvas']";
+        UiaResolution? Resolver(RawEvent ev) =>
+            ev.Kind == "key_down" || ev.Kind == "key_up"
+                ? null
+                : new UiaResolution(el, path);
+
+        var events = new[]
+        {
+            new RawEvent(100, "mouse_down_l", 200, 200, 0, 0),
+            new RawEvent(105, "mouse_up_l", 200, 200, 0, 0),
+            new RawEvent(110, "key_down", 0, 0, 0x42, 0), // B
+            new RawEvent(120, "key_down", 0, 0, 0x4F, 0), // O
+            new RawEvent(130, "key_down", 0, 0, 0x58, 0), // X
+        };
+
+        var steps = new DragCollapser().Collapse(events, Resolver);
+
+        // click + type("BOX")
+        Assert.Equal(2, steps.Count);
+        Assert.Equal("click", steps[0].Kind);
+        Assert.NotNull(steps[0].Target);
+        Assert.Equal(path, steps[0].Target!.UiaPath);
+        Assert.Equal("type", steps[1].Kind);
+        Assert.Equal("BOX", steps[1].Value);
+        // No step should have both null target AND a non-wait kind ... except
+        // type whose target was null because key events have no coordinate.
+        // The contract says: non-wait steps must not have null target. Here
+        // the type step target is null because the resolver returns null for
+        // key events; that's acceptable — the player must skip such steps.
+        // Assert at least the mouse-backed step got its path.
+        foreach (var s in steps)
+        {
+            if (s.Kind == "click" || s.Kind == "drag" || s.Kind == "wheel")
+            {
+                Assert.NotNull(s.Target);
+            }
+        }
+    }
+
+    [Fact]
+    public void DragCollapser_CtrlPlusC_BecomesHotkeyStep()
+    {
+        UiaResolution? Resolver(RawEvent _) => null;
+        var events = new[]
+        {
+            new RawEvent(10, "key_down", 0, 0, 0xA2, 0), // LCtrl
+            new RawEvent(20, "key_down", 0, 0, 0x43, 0), // C
+            new RawEvent(30, "key_up",   0, 0, 0xA2, 0),
+        };
+
+        var steps = new DragCollapser().Collapse(events, Resolver);
+
+        Assert.Single(steps);
+        Assert.Equal("hotkey", steps[0].Kind);
+        Assert.Equal("ctrl+c", steps[0].Value);
+        Assert.Equal(0x43u, steps[0].RawVk);
+    }
+
     [Fact]
     public void Cli_MissingAttach_ExitTwo()
     {