3 lines
2.8 KiB
JSON
3 lines
2.8 KiB
JSON
{
|
|
"body": "[Codex #1] Stage 2: simulation-plan review Round #1\n\n=== IMPLEMENTATION_UNITS ===\n- id: u1\n summary: Extend classify_visual_runtime_check to consume image_events and table_events, remove passed early-return, and widen visual_check_passed semantics\n files: [src/phase_z2_classifier.py]\n tests: [tests/phase_z2/test_phase_z2_visual_classifier.py]\n estimate_lines: 45\n- id: u2\n summary: Add pure-dict classifier tests for image aspect mismatch, below-tolerance image delta, standalone table overflow, and wrapper-clipped table dedup\n files: [tests/phase_z2/test_phase_z2_visual_classifier.py]\n tests: [tests/phase_z2/test_phase_z2_visual_classifier.py]\n estimate_lines: 45\n\nu1 rationale:\n- Covers the single execution-3 axis: classifier consumer extension for existing image_events and table_events arrays.\n- Uses src/phase_z2_pipeline.py constants as SSoT imports; no pipeline production or router behavior is touched.\n- Keeps existing zone-self and clipped_inner cascade intact while allowing image/table classifications to fail visual_check_passed even when overflow.passed is true.\n\nu2 rationale:\n- Covers all four required tests in the issue body and keeps them pure-dict with no Selenium dependency.\n- Test list is non-empty and points at the new classifier test file; each acceptance category/dedup path has one focused case.\n- The unit writes one file and stays under the 50-line implementation-unit limit target.\n\nOut-of-scope notes:\n- No changes to pipeline.py production of image_events/table_events, debug.json passthrough, router action selection, placement_diagnostics shape, or existing 8-rule zone cascade behavior.\n- No sample-specific logic, MDX hardcoding, or frame-specific shortcuts are part of this plan.\n\nRollback strategy:\n- Revert only src/phase_z2_classifier.py and tests/phase_z2/test_phase_z2_visual_classifier.py if Stage 3/4 verification fails.\n\n=== EVIDENCE ===\nCommands run:\n- Get-Content src/phase_z2_classifier.py first 470 lines\n- Get-Content src/phase_z2_pipeline.py first 160 lines\n- Get-ChildItem tests/phase_z2\n- git status --short\n- pytest -q tests\nFiles checked:\n- src/phase_z2_classifier.py\n- src/phase_z2_pipeline.py\n- tests/phase_z2\nTest results:\n- pytest -q tests -\u003e 192 passed in 40.40s\nVerified facts:\n- classify_visual_runtime_check still early-returns when overflow.passed is true, so removing that early return is necessary for image/table event scans.\n- IMAGE_ASPECT_DELTA_TOL = 0.05 and TABLE_SCROLL_TOL_PX = 5 exist in src/phase_z2_pipeline.py.\n- Existing tests/phase_z2 directory has no test_phase_z2_visual_classifier.py yet, so the planned test file is correctly new.\n- Both implementation units are \u003c=50 estimated lines and touch \u003c=3 files.\n- The plan covers every issue-body acceptance test and includes rollback/out-of-scope boundaries.\n\nFINAL_CONSENSUS: YES\n"
|
|
} |