|
|
c53722ad0b
|
feat(#86): IMP-86 u1~u5 placeholder zones_data + invariant guard
Mapper FitError handler now appends a __empty__ placeholder to zones_data
and a matching debug_zone so the surviving cardinality stays in sync with
the active layout preset's grid rows. A pre-build_layout_css invariant
guard fails fast with preset/positions/count diagnostics if drift recurs.
Per-record telemetry (adapter_needed, mapper_fit_error, provisional) is
exposed on both placeholder records; authoritative slide_status.adapter_
needed_units schema is unchanged.
Closes mdx03 reject override regression: Step 12 AI router now reachable
without heights_px ValueError; default-path behavior unaffected.
u1 — FitError placeholder zones_data + debug_zone (src/phase_z2_pipeline.py)
u2 — pre-build_layout_css invariant guard (src/phase_z2_pipeline.py)
u3 — horizontal-2 normal+placeholder helper unit (test_compute_per_zone_geometry.py)
u4 — mdx03 reject override → Step 12 integration + default regression
u5 — placeholder telemetry surface (adapter_needed/mapper_fit_error/provisional)
Tests:
- u3 helper: 7 passed (0.06s)
- u4+u5 integration: 2 passed (7.87s)
- Phase Z2 + AI fallback regression: 544 passed (66.28s)
- Broader sweep (excl. matching/pipeline heavy): 1066 passed (96.12s)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
2026-05-23 18:25:14 +09:00 |
|
|
|
f3ef4d917c
|
feat(#64): IMP-35 details_popup_escalation u1~u10 + Stage 3 R7 anchor re-pin
Land the production + test surface for the Step 17 cascade POPUP terminal
(DETERMINISTIC -> POPUP -> AI_REPAIR -> USER_OVERRIDE) per Stage 2 plan R2.
u11 (baseline-red invariance gate) was already landed in 7c93031 ahead of
this commit; this commit completes u1~u10 plus the Stage 3 R7 follow-up
anchor re-pin for test_imp17_comment_anchor.py.
Implementation units (Stage 2 R2 contract):
u1 frame_reselect_insufficient failure_type + post-frame remeasure (q4)
- src/phase_z2_failure_router.py, src/phase_z2_pipeline.py
u2 NEXT_ACTION_BY_FAILURE row + impl_status flip
- src/phase_z2_failure_router.py
u3 Router details_popup_escalation MISSING->IMPLEMENTED + executor stub
- src/phase_z2_router.py
u4 step17.py AI split-decision contract (POPUP cascade_stage +
route_for_label + skip_reason); API gated
- src/phase_z2_ai_fallback/step17.py
u5 Step 17 POPUP gate executor; popup_escalation_plan + has_popup marker
- src/phase_z2_pipeline.py, src/phase_z2_ai_fallback/step17.py
u6 Composition popup binding -- yaml strategy -> zone payload
- src/phase_z2_composition.py
u7 Pipeline composer -> render_slide wiring
(popup_html / preview_text / has_popup)
- src/phase_z2_pipeline.py
u8 slide_base.html <details>/<summary> popup wrapper
- templates/phase_z2/slide_base.html
u9 display_strategies.yaml inline_preview + popup metadata
- templates/phase_z2/regions/display_strategies.yaml
u10 MDX preservation invariant: popup=full source / body=summary or subset
(asserted by tests/phase_z2/test_popup_mdx_preservation.py)
u11 (already in 7c93031) -- baseline-red invariance gate
Stage 3 R7 follow-up (anchor re-pin, test-only):
- tests/orchestrator_unit/test_imp17_comment_anchor.py
Pre-anchor additions in src/phase_z2_pipeline.py (u1 / u5 / u7) shifted
the restructure/reject route-hint comments 578/579 -> 586/587. Re-pinned
the two guard tests (and docstring re-pin lineage 564 -> 570 -> 578 ->
586). Production code untouched.
Verification (Stage 4 R1):
pytest -q tests/orchestrator_unit/test_imp17_comment_anchor.py
-> 2 passed / 0.02s
pytest -q <10 IMP-35 unit files in tests/phase_z2 + tests/phase_z2_ai_fallback>
-> 136 passed / 15.94s
Baseline-red invariance gate
(tests/test_imp47b_step12_ai_wiring.py +
tests/test_phase_z2_ai_fallback_config.py)
-> 4 failed / 6 passed; FAILED set === IMP35_BASELINE_RED_NODE_IDS
(frozen registry from 7c93031). Contract holds.
Codex Stage 4 R1 = YES (independent verify).
Guardrails honored:
- MDX content preservation: popup carries full source, body holds
summary or subset only (CLAUDE.md 자세히보기 원칙;
feedback_phase_z_spacing_direction -- capacity expanded, no margin shrink).
- AI isolation contract: Step 17 POPUP gate is deterministic; AI hook
surface is split-decision contract only, API call gated.
- No hardcoding: escalation thresholds derived from existing overflow
detector outputs; preview_chars deterministic from container px.
- 1 commit = 1 decision unit: u1~u10 land together as the planned
production surface; u11 was deliberately split into 7c93031 as Stage 3
R7 carve-out, and the R7 anchor re-pin rides with this commit because
it is the direct shift consequence of the u1/u5/u7 pre-anchor additions.
- Scope-locked: .claude/settings.json explicitly excluded
(Stage 4 exit report contract).
Out of scope (per Stage 1 + Stage 2):
- AI_REPAIR API activation (post IMP-35 axis).
- IMP-34 zone resize, IMP-36 responsive fit (chain partners,
separate issues).
- Print-time auto-expand JavaScript for <details>.
- Popup escalation in stages other than Step 17.
- Baseline-red body repair (4 frozen failures) -- separate follow-up
issue; u11 only guards the count.
- frame_reselect algorithm changes (entry point only).
- templates/phase_z2/slide_base.html path rename.
source_comment_ids:
Stage 1: claude_stage1_problem_review_imp35, codex_stage1_verification_imp35_yes
Stage 2: Claude #4 R2 plan, Codex #5 R2 YES
Stage 3: Claude #86 (R7 anchor re-pin), Codex #87 YES
Stage 4: Claude #88 R1, Codex #89 R1 YES
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
2026-05-23 07:36:57 +09:00 |
|
